Open
Conversation
Owner
|
Hi, sorry I didn't had time to reply to the clarification ticket, some remarks:
Otherwise, thanks, I see that I made a lot of typos :] |
Author
|
1. To my mind, stroking is something you do to a cat, but if it's the
accepted term, I'll undo the changes I made :P
2. I'll have a second look at that one.
3. Yeah, I thought as much. I should've turned off stylish-haskell straight
away. I'll fix that.
You're very welcome. Is there anything else that you'd like to do with this
library, that you might not have time for yourself at the moment?
2017-09-20 13:56 GMT+02:00 Vincent Berthoux <notifications@github.com>:
… Hi, sorry I didn't had time to reply to the clarification ticket, some
remarks:
- Stroking is an accepted term in the domain, I wouldn't change it
- Will -> Fill doesn't makes sense, maybe just removing the word would
work.
- I'm don't like the alignment of imports (a pita to maintain it) and
various free indentation changes, as it breaks the history.
Otherwise, thanks, I see that I made a lot of typos :]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC5zBGjdKCGesQpxxUjbw1o80sIMpYczks5skP1XgaJpZM4PdbFn>
.
--
Hälsningar
Jonatan H Sundqvist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry about the auto-formatting stuff, I'll fix it if it's too much.